Attention is currently required from: fixeria, osmith, pespin.
Hello Jenkins Builder, fixeria, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder
Change subject: Fix lint errors: don't use star imports
......................................................................
Fix lint errors: don't use star imports
tests/test_tlv.py:21:1: F403 `from osmocom.tlv import *` used; unable to detect
undefined names
|
19 | import unittest
20 | from construct import Int8ub, GreedyBytes
21 | from osmocom.tlv import *
| ^^^^^^^^^^^^^^^^^^^^^^^^^ F403
22 | from osmocom.utils import h2b
Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266
---
M src/osmocom/gsmtap.py
M tests/test_construct.py
M tests/test_gsup.py
M tests/test_tlv.py
M tests/test_utils.py
5 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom
refs/changes/84/41384/3
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266
Gerrit-Change-Number: 41384
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
