Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email )
Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 3: (1 comment) File tests/test_construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/c7d5f7a5_eb04eb49?usp=email : PS2, Line 8: DnsAdapter, > The usual approach in our code would be to simply have two (or more) lines > starting with "from osmocom.construct import ...". > See > https://gitea.osmocom.org/osmocom/pyosmocom/src/commit/a5bc2a20f439f2ab309a38bfa6e2cf4266e9c11a/src/osmocom/construct.py#L14 > for example, > where we have three lines doing "from construct import ..." Changed it to that style, please have another look. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: laforge <[email protected]>
