Patch Set 3: Code-Review-1 I think it makes a lot of sense separating these already in this commit. Better have a OsmoMobile and OsmoVirtPhy classes (put them in the same file if it is easier for you). Have a look for instance at osmo_bsc.py or bts_osmo_trx.py.
-- To view, visit https://gerrit.osmocom.org/6917 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: No
