Patch Set 6:

(1 comment)
File src/common/msg_utils.c:

Line 489:               if (!!lchan->tch.dtx.len)
I am still unsure about this use of '!!'.

It looks much like an accidental typo where '!' was intended.

Or is it really a check for a zero-length frame? If so, why not write it as 
dtx.len == 0?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-PatchSet: 6
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <>
Gerrit-Reviewer: Minh-Quang Nguyen <>
Gerrit-Reviewer: Pau Espin Pedrol <>
Gerrit-Reviewer: Stefan Sperling <>
Gerrit-Reviewer: Vadim Yanitskiy <>
Gerrit-HasComments: Yes

Reply via email to