Patch Set 6: (1 comment)
https://gerrit.osmocom.org/#/c/5753/6/src/common/msg_utils.c File src/common/msg_utils.c: Line 489: if (!!lchan->tch.dtx.len) I am still unsure about this use of '!!'. It looks much like an accidental typo where '!' was intended. Or is it really a check for a zero-length frame? If so, why not write it as dtx.len == 0? -- To view, visit https://gerrit.osmocom.org/5753 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6 Gerrit-PatchSet: 6 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
