Patch Set 6:

(1 comment)
File src/common/msg_utils.c:

Line 489:               if (!!lchan->tch.dtx.len)
> I am still unsure about this use of '!!'.
This is basically done to transform an integer into a boolean, ie: var>=0 -> 
var=1, but I agree in this place it doesn't make much sense and we can simply 
if (lchan->tch.dtx.len!=0)


if (lchan->tch.dtx.len)

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-PatchSet: 6
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <>
Gerrit-Reviewer: Minh-Quang Nguyen <>
Gerrit-Reviewer: Pau Espin Pedrol <>
Gerrit-Reviewer: Stefan Sperling <>
Gerrit-Reviewer: Vadim Yanitskiy <>
Gerrit-HasComments: Yes

Reply via email to