Patch Set 6: (1 comment)
https://gerrit.osmocom.org/#/c/5753/6/src/common/msg_utils.c File src/common/msg_utils.c: Line 489: if (!!lchan->tch.dtx.len) > I am still unsure about this use of '!!'. This is basically done to transform an integer into a boolean, ie: var>=0 -> var=1, but I agree in this place it doesn't make much sense and we can simply do: if (lchan->tch.dtx.len!=0) or if (lchan->tch.dtx.len) -- To view, visit https://gerrit.osmocom.org/5753 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6 Gerrit-PatchSet: 6 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.ngu...@nutaq.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.ngu...@nutaq.com> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
