Patch Set 7:

(2 comments)

https://gerrit.osmocom.org/#/c/5753/7/src/common/msg_utils.c
File src/common/msg_utils.c:

Line 489:               if (!!lchan->tch.dtx.len)
imho we can simplify the !!.


https://gerrit.osmocom.org/#/c/5753/7/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:

Line 365:       LOGP(DL1C, LOGL_DEBUG, "%s tn=%u: Sending fill frame on in none 
DTX mode "
This text is really confusing.


-- 
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-PatchSet: 7
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.ngu...@nutaq.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.ngu...@nutaq.com>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to