Patch Set 7:

File src/common/msg_utils.c:

Line 489:               if (!!lchan->tch.dtx.len)
imho we can simplify the !!.
File src/osmo-bts-litecell15/l1_if.c:

Line 365:       LOGP(DL1C, LOGL_DEBUG, "%s tn=%u: Sending fill frame on in none 
DTX mode "
This text is really confusing.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-PatchSet: 7
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <>
Gerrit-Reviewer: Minh-Quang Nguyen <>
Gerrit-Reviewer: Pau Espin Pedrol <>
Gerrit-Reviewer: Stefan Sperling <>
Gerrit-Reviewer: Vadim Yanitskiy <>
Gerrit-HasComments: Yes

Reply via email to