Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9716 )
Change subject: ms: Quit early when all tests concluded.. ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/9716/1/src/osmo_ms_driver/location_update_test.py File src/osmo_ms_driver/location_update_test.py: https://gerrit.osmocom.org/#/c/9716/1/src/osmo_ms_driver/location_update_test.py@181 PS1, Line 181: return reduce(lambda b, ms: b and ms.has_lu_time(), self._results.values(), True) Not related to this commit itself, but this looks really computation intesive given tht you are running a lot of ms and you are checking this everytime you select (or timeout). May be worth moving this to a counter you increase and decrease and simply check for counter to be 0. -- To view, visit https://gerrit.osmocom.org/9716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179 Gerrit-Change-Number: 9716 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 10:09:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
