Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9716 )
Change subject: ms: Quit early when all tests concluded.. ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/9716/3/src/osmo_ms_driver/location_update_test.py File src/osmo_ms_driver/location_update_test.py: https://gerrit.osmocom.org/#/c/9716/3/src/osmo_ms_driver/location_update_test.py@82 PS3, Line 82: self._outstanding = len(self._unstarted) > Why? Would you mind to elaborate of why this is the better number? Because you already have the value in a variable, so no need to calculate or get it from a function. And it's also easier to find out where the final value comes from, without having to look at the loop to find out it comes from a parameter. But as I said, it's fine too the way you did it, so no need to change the commit. I was just giving my opinion/thoughts after seeing the code. -- To view, visit https://gerrit.osmocom.org/9716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179 Gerrit-Change-Number: 9716 Gerrit-PatchSet: 3 Gerrit-Owner: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 15 Jul 2018 22:06:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No