Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/9716 )
Change subject: ms: Quit early when all tests concluded.. ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/9716/3/src/osmo_ms_driver/location_update_test.py File src/osmo_ms_driver/location_update_test.py: https://gerrit.osmocom.org/#/c/9716/3/src/osmo_ms_driver/location_update_test.py@82 PS3, Line 82: self._outstanding = len(self._unstarted) > I'd say using number_of_ms would be more clear here, but fine anyway :) Why? Would you mind to elaborate of why this is the better number? -- To view, visit https://gerrit.osmocom.org/9716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179 Gerrit-Change-Number: 9716 Gerrit-PatchSet: 3 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sat, 14 Jul 2018 14:36:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
