Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9652 )
Change subject: tweak the default point codes used by sccp_demo_user ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG@17 PS1, Line 17: -1 As far as I can see, the old code was using -1, not the new code? (leaving that aside, I don't even remember what -1 was intended to signify) https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG@22 PS1, Line 22: Use the same default values for both client and : server modes this wording would mean that both the client and server want to use "23" as local code and "1" as remote point code, and they cannot connect to each other? I suppose this is not what you meant to say? -- To view, visit https://gerrit.osmocom.org/9652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229 Gerrit-Change-Number: 9652 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 03 Jul 2018 11:45:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
