Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9652 )
Change subject: tweak the default point codes used by sccp_demo_user ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/9652/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9652/3//COMMIT_MSG@8 PS3, Line 8: Easier to understand: "sccp demo: use point code 23 for server and 1 for client. Fix previous commit 4dc... which broke this by using -1 for local and 23 for remote PC, for both server and client." That's all, is it? https://gerrit.osmocom.org/#/c/9652/3//COMMIT_MSG@27 PS3, Line 27: While here, remove unused -p option from getopt() argument list. hm, maybe rather separate -- To view, visit https://gerrit.osmocom.org/9652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229 Gerrit-Change-Number: 9652 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 00:13:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
