Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9652 )
Change subject: tweak the default point codes used by sccp_demo_user ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG@17 PS1, Line 17: -1 > As far as I can see, the old code was using -1, not the new code? (leaving > that aside, I don't even […] The old code (before 4dc9088cabedc40cb9072814237ad5926b12bd35) was passing -1 for port numbers, not point codes. I believe in this context -1 means "use any port". The server was using point code 1, and expected the client to use point code 23. The client was using point code 23. One mistake in 4dc9088cabedc40cb9072814237ad5926b12bd35 was that I set the LOCAL_PC to -1 instead of 1 (got mixed up between ports and point codes). I understand that having sccp_demo_user client/server talk to each other out of the box will be useful. I will try to keep it working that way in the next patch set. -- To view, visit https://gerrit.osmocom.org/9652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229 Gerrit-Change-Number: 9652 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 15:21:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
