Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11606 )
Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11606/2/src/osmo-bsc/gsm_04_08_rr.c File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/#/c/11606/2/src/osmo-bsc/gsm_04_08_rr.c@957 PS2, Line 957: /* conn shall release lchan on teardown, also if this Layer 3 Complete is rejected. */ > now this comment is not in line with the above. […] returns bool: it's fixed in previous patch in gerrit: https://gerrit.osmocom.org/#/c/osmo-bsc/+/11605/ -- To view, visit https://gerrit.osmocom.org/11606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1743f9d5cd0fdbc0fb9afe7bcc0271c897915210 Gerrit-Change-Number: 11606 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 13 Nov 2018 12:06:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
