Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11606 )
Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11606/1/src/osmo-bsc/gsm_04_08_rr.c File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/#/c/11606/1/src/osmo-bsc/gsm_04_08_rr.c@955 PS1, Line 955: return -1; I think you could just 'return rc' from here. https://gerrit.osmocom.org/#/c/11606/1/tests/gsm0408/gsm0408_test.c File tests/gsm0408/gsm0408_test.c: https://gerrit.osmocom.org/#/c/11606/1/tests/gsm0408/gsm0408_test.c@955 PS1, Line 955: gscon_release_lchans Could you please clarify, how is this related to the change? You're introducing a new symbol that is not used anywhere. -- To view, visit https://gerrit.osmocom.org/11606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1743f9d5cd0fdbc0fb9afe7bcc0271c897915210 Gerrit-Change-Number: 11606 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 22:22:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
