Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11606 )

Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11606/1/tests/gsm0408/gsm0408_test.c
File tests/gsm0408/gsm0408_test.c:

https://gerrit.osmocom.org/#/c/11606/1/tests/gsm0408/gsm0408_test.c@955
PS1, Line 955: gscon_release_lchans
> Could you please clarify, how is this related to the change? […]
Otherwise linker fails with an error, probably because the C file containing 
those symbols is not included statically into the binary. I just took same 
approach already used, see bsc_subscr_con_allocate above.



--
To view, visit https://gerrit.osmocom.org/11606
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1743f9d5cd0fdbc0fb9afe7bcc0271c897915210
Gerrit-Change-Number: 11606
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Tue, 06 Nov 2018 10:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to