dexter has posted comments on this change. ( https://gerrit.osmocom.org/11728 )
Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED ...................................................................... Patch Set 1: (2 comments) > (2 comments) (making sure all comments get posted) https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c@894 PS1, Line 894: msgb_tlv_put(msg, GSM0808_IE_CAUSE, params->cause & 0x80 ? 2 : 1, (const uint8_t *)¶ms->cause); > I'm also not so sure whether this is identical on both big- and > little-endian. […] Can you give me some more information on this. If this way is problematic we have a problem in other cases too gsm0808_create_handover_failure() does it the same way. https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c@897 PS1, Line 897: lai_ci.ident = CELL_IDENT_WHOLE_GLOBAL; > Yes, please let the caller decide on the specific cell identity type (add a > struct gsm0808_cell_id t […] I oriented myself on gsm0808_create_layer3_2(), which does the encoding the same way. I think there shouldn't be two different encodings for the same parameter type in one API. (I am not sure, the value is populated from cgi_for_msc(), i don't see it yet, probably I then need to transcode the result) -- To view, visit https://gerrit.osmocom.org/11728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825106858bd89afc9837811b8fed2e8accc82441 Gerrit-Change-Number: 11728 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Nov 2018 12:44:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
