Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 )
Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c@894 PS1, Line 894: > Can you give me some more information on this. […] frankly I'm not sure at all; and also it seems we don't really care about big endian after all... I don't really understand why then we have so many #if OSMO_IS_BIG_ENDIAN around the code in the first place, but seems we're generally broken on big endian. So if it works on L.E. maybe not bother... https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c@897 PS1, Line 897: > I oriented myself on gsm0808_create_layer3_2(), which does the encoding the > same way. […] the gsm0808_create_layer3 precedes the cell identity encoding API. I wasn't consciously aware of that other implementation in that function, and you're right that that should probably also be fixed to use the new cell identity encoding function gsm0808_enc_cell_id(). The point being here: you can make this code both more flexible and simpler by just asking the caller to provide a struct gsm0808_cell_id and passing it on to gsm0808_enc_cell_id(). thanks! -- To view, visit https://gerrit.osmocom.org/11728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825106858bd89afc9837811b8fed2e8accc82441 Gerrit-Change-Number: 11728 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 19 Nov 2018 16:36:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
