Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11932 )
Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT ...................................................................... Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/11932/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11932/1//COMMIT_MSG@12 PS1, Line 12: 20181123044720655 cosmetic: I think timestamps are useless here. https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/l1_if.c@162 PS1, Line 162: TN "... param (tn=%u)\n" would be a bit more informative. https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/l1_if.c@167 PS1, Line 167: 13 where does this number come from? https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/l1_if.c@168 PS1, Line 168: TS_TYPE same here: "... param (ts_type=%u)\n" https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.h File src/osmo-bts-trx/trx_if.h: https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.h@15 PS1, Line 15: void Why void? Why not 'trx_if_cmd_setslot_cb *cb'? -- To view, visit https://gerrit.osmocom.org/11932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c Gerrit-Change-Number: 11932 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 14:27:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
