Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11932 )
Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.h File src/osmo-bts-trx/trx_if.h: https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.h@15 PS1, Line 15: void > Why void? Why not 'trx_if_cmd_setslot_cb *cb'? Because it's a generic cb pointer, which can be used by kind of message later on. As I'm extending this kind of RSP checks, I foresee that I'll need more callbacks in the future for similar stuff than added in this commit. It's far more extensible (yet without adding complexity) having a callback set per message instead of global one or per type or whatever. https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.c@199 PS1, Line 199: trx_ctrl_cmd > I would rather introduce a new symbol, e.g. trx_ctrl_cmd_cb(). that makes no sense since here the cb is per message and the trx_ctrl_msg is created inside the function and not returned, so here is fine. https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.c@259 PS1, Line 259: NULL > ... so this would allow to avoid passing NULL everywhere. I foresee expanding cb use in the future, so it makes sense to keep it like this. -- To view, visit https://gerrit.osmocom.org/11932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c Gerrit-Change-Number: 11932 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 15:07:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
