Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11932 )
Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11932/3/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/#/c/11932/3/src/osmo-bts-trx/l1_if.c@163 PS3, Line 163: PRIu8 > AFAIK, we usually use '%u' for uint8_t. Not critical though. I think it's more clear to use PRIu8 when using uint8_t. -- To view, visit https://gerrit.osmocom.org/11932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c Gerrit-Change-Number: 11932 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 18:03:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
