Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11932 )
Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT ...................................................................... Patch Set 5: Code-Review+2 (1 comment) I still don't see thru the code changes, but if you say it fixes it and harald's earlier +2 are enough for me https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG@32 PS4, Line 32: 20181123044720705 DTRX trx_if.c:492 Response message: 'RSP SETSLOT 0 6 1' yes, but timestamps in a commit log ... about putting the filename in the end: the aim is that the logging context lines up: we often log the same context throughout a .c file, and it helps me a lot to spot stuff going on with a given context if that is always printed at the same indent. Especially if the same fsm instance is logged at from different source files. > I'll submit a new version removing the category log for this patch. would have been fine, was just suggesting changes for future patches -- To view, visit https://gerrit.osmocom.org/11932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c Gerrit-Change-Number: 11932 Gerrit-PatchSet: 5 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 16:56:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
