Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11932 )
Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG@10 PS4, Line 10: into account if TRX succeeded or failed to set the TS: > are we talking bootstrapping the BTS in the beginning? No, during bootstap afair no PDCH DEACT is sent, it's simply configured through OML. https://gerrit.osmocom.org/#/c/11932/4//COMMIT_MSG@32 PS4, Line 32: 20181123044720705 DTRX <000b> trx_if.c:492 Response message: 'RSP SETSLOT 0 6 1' > since you're posting a lot of logging in commit logs lately... […] I actually like having the timestamp, as I stated in another review recently. It gives me more information about timings of events and allows discarding some actions like timers, etc. which may interfere. "dropping category-hex, instead adding the loglevel as explicit string". Actually I like this idea, thanks for the advise and providing required config :) I actually didn't even notice that hex stuff was the category in hex lol. src line I don't want to omit, it helps me a lot understand log traces. About putting it to the end, that's a personal preference. I'll submit a new version removing the category log for this patch. -- To view, visit https://gerrit.osmocom.org/11932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c Gerrit-Change-Number: 11932 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 17:58:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
