Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/10185/4/include/osmocom/gsm/gsm48_arfcn_range_encode.h File include/osmocom/gsm/gsm48_arfcn_range_encode.h: https://gerrit.osmocom.org/#/c/10185/4/include/osmocom/gsm/gsm48_arfcn_range_encode.h@8 PS4, Line 8: OSMO_GSM48_ARFCN_RANGE_INVALID = -1, (gerrit shows an indenting mismatch... personally I'd just drop the tabs but ok if they line up) https://gerrit.osmocom.org/#/c/10185/4/src/gsm/gsm48_arfcn_range_encode.c File src/gsm/gsm48_arfcn_range_encode.c: https://gerrit.osmocom.org/#/c/10185/4/src/gsm/gsm48_arfcn_range_encode.c@6 PS4, Line 6: * (C) 2012 by On-Waves add (C) 2018 sysmocom - s.f.m.c. GmbH? -- To view, visit https://gerrit.osmocom.org/10185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c Gerrit-Change-Number: 10185 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Holger Freyther <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 15:57:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
