Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/10185/5/src/gsm/gsm48_arfcn_range_encode.c File src/gsm/gsm48_arfcn_range_encode.c: https://gerrit.osmocom.org/#/c/10185/5/src/gsm/gsm48_arfcn_range_encode.c@213 PS5, Line 213: k, wk_len, octet_offs, bit_offs, level, lvl_left); > ah damn. I think in a libosmocore utility function like this we shouldn't log > though? not sure... Since these looks like ad-hoc debug printfs, I'll just remove them. https://gerrit.osmocom.org/#/c/10185/5/tests/gsm0408/gsm0408_test.c File tests/gsm0408/gsm0408_test.c: https://gerrit.osmocom.org/#/c/10185/5/tests/gsm0408/gsm0408_test.c@618 PS5, Line 618: int arfcns_num, int silent) > (weird indent .. […] Yes, copied along. I'll fix it. https://gerrit.osmocom.org/#/c/10185/5/tests/gsm0408/gsm0408_test.c@941 PS5, Line 941: log_init(&log_info, NULL); > Usually in regression tests, to get reproducable output I have to call: […] Looks like no logging is needed. I'll remove this stuff. -- To view, visit https://gerrit.osmocom.org/10185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c Gerrit-Change-Number: 10185 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Holger Freyther <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:51:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
