Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc ...................................................................... Patch Set 6: (3 comments) https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c File tests/gsm0408/gsm0408_test.c: https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@33 PS6, Line 33: #include <osmocom/core/logging.h> > not needed Right, dropped. https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@116 PS6, Line 116: printf(" is: %s\n", osmo_hexdump(msg->data, msg->len)); > maybe a bit eager find-replace? I think this stderr output should also go to > stdout, yes, but techni […] Oh, I understood that you wanted all fprintf() in this file to be printf() for some reason. Reverted in next patch set. https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@914 PS6, Line 914: }; > drop this too Done. -- To view, visit https://gerrit.osmocom.org/10185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c Gerrit-Change-Number: 10185 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-CC: Holger Freyther <hol...@freyther.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 13:17:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
