Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding ...................................................................... Patch Set 16: > Patch Set 16: > > > > it's either all or nothing. > > > > That's not the case: we might fail in the middle of decoding after > > some values have already been written out. > > I don't see the API defining those different cases nor this test code > checking different cases through return code, so yes, its "all or nothing" > (and it's fine being that way). Agreeing with pau here -- To view, visit https://gerrit.osmocom.org/12020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 16 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sat, 08 Dec 2018 19:39:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
