Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding ...................................................................... Patch Set 18: (1 comment) https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586 PS4, Line 586: { > Since the opinions differ I'd rather keep the code as it is because I find it > easier to read. […] Pretty poor show, guys, how you dismiss a sound argument by not naming sources nor examples (Pau) and not even mentioning why it is not convincing (Max). If you declare the argument closed, then have something to show for it besides "I once read somewhere" and "nah you know, mh-nah". It makes me not want to spend time on your code. I'm going to let this one go because it's just a zero, but next time please be a little more considerate. -- To view, visit https://gerrit.osmocom.org/12020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 18 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Wed, 12 Dec 2018 12:14:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
