Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding ...................................................................... Patch Set 17: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12020/17/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12020/17/tests/gsm0808/gsm0808_test.c@1864 PS17, Line 1864: osmo_init_logging2(talloc_named_const(NULL, 0, "gsm0808 test"), NULL); is there any logging being added? if we really need this, I prefer void *ctx = talloc_named_const... msgb_talloc_ctx_init(ctx, 0); osmo_init_logging2(ctx,...); and possibly trace the logging in expected stderr output; related logging setup explanation: https://gerrit.osmocom.org/c/libosmocore/+/10185/5/tests/gsm0408/gsm0408_test.c#941 -- To view, visit https://gerrit.osmocom.org/12020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 17 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:20:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
