Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12227 )
Change subject: ACL: integrate sanitize check into sgsn_acl_* functions ...................................................................... Patch Set 2: (1 comment) So I'm fine with moving it into a function, but I think the function should be called by the caller of sgsn_acl_* only if needed, not always inside sgsn_acl_* https://gerrit.osmocom.org/#/c/12227/2/src/gprs/sgsn_vty.c File src/gprs/sgsn_vty.c: https://gerrit.osmocom.org/#/c/12227/2/src/gprs/sgsn_vty.c@a650 PS2, Line 650: > In which library it's defined? sorry, I meant the imsi_sanitize() you add in this commit. -- To view, visit https://gerrit.osmocom.org/12227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9 Gerrit-Change-Number: 12227 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 10 Dec 2018 18:03:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
