Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808/gsm0808_test.c@586 PS4, Line 586: struct gsm29205_gcr g = { .net_len = 3, .node = 0xDEAD }, p = { 0 }; > Pretty poor show, guys, how you dismiss a sound argument by not naming > sources nor examples (Pau) an […] You could call your show about answering one week later poor too, I may have remembered better what I read and could more easily provide more feedback, and I already lost too much time with this detail, I don't want to spend it a second time trying to find the exact commit and web page with the information. -- To view, visit https://gerrit.osmocom.org/12020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 4 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Wed, 12 Dec 2018 12:33:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
