Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12321 )
Change subject: vty: Introduce telnet_init_default and make vty port configurable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/12321/1/src/vty/telnet_interface.c@111 PS1, Line 111: * \param[in] default_port UDP port number to use if not explicitely configured UDP? Doesn't telnet/VTY run over TCP in this universe? -- To view, visit https://gerrit.osmocom.org/12321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5fb2faaf4311bd7284ee870526a6f87b7e260f3 Gerrit-Change-Number: 12321 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 17 Dec 2018 10:31:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
