Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/12321 )
Change subject: vty: Make TCP port configurable and introduce telnet_init_default ...................................................................... Patch Set 3: > Patch Set 1: Code-Review-1 > > (4 comments) > > I still would like to see a better commit description. "better" is not very actionable. What do you think can/should be better in the commit description? -- To view, visit https://gerrit.osmocom.org/12321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5fb2faaf4311bd7284ee870526a6f87b7e260f3 Gerrit-Change-Number: 12321 Gerrit-PatchSet: 3 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sat, 22 Dec 2018 16:50:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
