Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/12321 )
Change subject: vty: Introduce telnet_init_default and make vty port configurable ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12321/1/include/osmocom/vty/vty.h File include/osmocom/vty/vty.h: https://gerrit.osmocom.org/#/c/12321/1/include/osmocom/vty/vty.h@214 PS1, Line 214: int vty_get_bind_port(int default_port); > Is there any use-case where we want to call vty_get_bind_port() with negative > value? To see if it has been set through the VTY. It is convenient to have elements outside the range settable by users. But it is not only negative but also everything above 16 bits. -- To view, visit https://gerrit.osmocom.org/12321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5fb2faaf4311bd7284ee870526a6f87b7e260f3 Gerrit-Change-Number: 12321 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sat, 22 Dec 2018 03:40:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
