Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg ...................................................................... Patch Set 3: > I was just replying that I still lack a "no ipa-name" in order to be able to > go back to default before saving the config, but I didn't really understand > your arguments against it, I was just stating I don't get them and trying to > explain why. I know your patch currently doesn't do that. OK, I see. I don't think 'no ipa-name' is a good idea, for the same reasons that changing the name at runtime is not a good idea. As I understand, the semantics of 'no ipa-name' would include switching the IPA name back to the default name at run-time, would it not? -- To view, visit https://gerrit.osmocom.org/12243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 17 Dec 2018 15:44:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
