Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg ...................................................................... Patch Set 3: > Not necessarily. I think I already described it. You could simply print it > won't be applied until next restart, but still give the option that it is > saved so next time you start it it will be taken into account. Otherwise user > really needs to modify the cfg file manually. I really don't see why a regular user would want to clear the name, write the config, and then configure the name again to prevent the network from falling apart: no ipa-name write file ipa-name 'SGSN-911-123456879' Just to save the effort of removing one line from the saved file? Considering that multi-SGSN and multi-MSC setups will be an exception rather than the norm, how often do you think users will even run into this? Do you have a concrete situation where you would use this yourself? Or are you arguing based on "consistency is good" (which it isn't in this case, I would say)? If I were an admin of such a network, I'd be incredibly happy to have a unique identifier in all my configuration files saved from different SGSN/MSC. -- To view, visit https://gerrit.osmocom.org/12243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 17 Dec 2018 16:09:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
