Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c File src/gprs/sgsn_vty.c: https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c@1195 PS3, Line 1195: if (!parsing_config_file) { > my question: do things break when changing during run-time? […] I can't enumerate the consequences of changing this name on the fly. What seems obvious is that changing this name will result in some IPA connections using name A and others using name B. Likewise for routes which get installed in the HLR which refers to these names, both of which point towards the same SGSN. Will this cause real harm? I cannot tell. Will connections using the old name be negatively impacted? Maybe. What I am pretty certain about is that it risks putting the system into an inconsistent state. What I also know is that this is an unprecedented use case because Osmocom has never run in multi-MSC/multi-SGSN setups which means that we cannot really judge the consequences based on past experience. We'd have to do a lot of testing and code audit to be sure of the consequences. And all that for what looks like an edge-case to me which should never happen in real multi-MSC/multi-SGSN deployments as far as I can tell. So I'll turn the question around on you again: Why would you want to change this name without also restarting the process? What is the use case for this? -- To view, visit https://gerrit.osmocom.org/12243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Tue, 18 Dec 2018 10:51:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
