dexter has posted comments on this change. ( https://gerrit.osmocom.org/12369 )
Change subject: LCLS: don't send invalid status in HO messages ...................................................................... Patch Set 1: (2 comments) > (1 comment) https://gerrit.osmocom.org/#/c/12369/1/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/12369/1/include/osmocom/gsm/gsm0808.h@a160 PS1, Line 160: > AFAIK, yes. […] When the _present flag is set to false, then the related value is not sent. https://gerrit.osmocom.org/#/c/12369/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/12369/1/src/gsm/gsm0808.c@901 PS1, Line 901: if (params->lcls_bss_status != GSM0808_LCLS_STS_NA) I am not sure if this is a good idea. GSM0808_LCLS_STS_NA = 0xFF, so one must never forget to initialize the field when creating the message. However, in the end its a matter of taste anyway. -- To view, visit https://gerrit.osmocom.org/12369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b Gerrit-Change-Number: 12369 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 17:12:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
