Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12369 )
Change subject: LCLS: don't send invalid status in HO messages ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12369/1/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/12369/1/include/osmocom/gsm/gsm0808.h@a160 PS1, Line 160: > When the _present flag is set to false, then the related value is not sent. Is this bit then set by the user of the API? If there's users using this API, we should modify them too. If not, then this code was wrong since this value was always false. BTW, we are breaking the API/ABI here. Was this field added after last release? If that's not the case, I see no good reason for breaking the ABI here. -- To view, visit https://gerrit.osmocom.org/12369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b Gerrit-Change-Number: 12369 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 17:59:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
