dexter has posted comments on this change. ( https://gerrit.osmocom.org/12369 )
Change subject: LCLS: don't send invalid status in HO messages ...................................................................... Patch Set 1: (1 comment) > Build Successful > > https://jenkins.osmocom.org/jenkins/job/gerrit-libosmocore/1353/ : > SUCCESS' --verified 1 --code-review 0 https://gerrit.osmocom.org/#/c/12369/1/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/12369/1/include/osmocom/gsm/gsm0808.h@a160 PS1, Line 160: > Is this bit then set by the user of the API? If there's users using this API, > we should modify them […] The bit is set by the API user. Probably its best to ask neels, he designed this part of the API. I just modeled the API of the handover performed message after what was already there. (I still don't get whats the problem here.) -- To view, visit https://gerrit.osmocom.org/12369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b Gerrit-Change-Number: 12369 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 08:02:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
