Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/12408 )
Change subject: GSUP: fix missing osmo_gsup_get_err_msg_type()s
......................................................................
Patch Set 1:
I don't think we can merely remove this function, because this is a library API.
We can either a) call the macro from it, or b) remove it and add an alias:
#define osmo_gsup_get_err_msg_type(t) \
OSMO_GSUP_TO_MSGT_ERROR(t)
Let's wait for Harald's response.
--
To view, visit https://gerrit.osmocom.org/12408
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I801a0d6ffe09cfc75b77ab602bd25b3dc40f19c0
Gerrit-Change-Number: 12408
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 21 Dec 2018 11:56:23 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
