osmith has posted comments on this change. ( https://gerrit.osmocom.org/12408 )

Change subject: GSUP: fix missing osmo_gsup_get_err_msg_type()s
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c@96
PS1, Line 96: osmo_gsup_get_err_msg_type
> while the existing GSUP message definitions "by coincidence" implicitly 
> follow the rule that the err […]
Done:
* https://gerrit.osmocom.org/#/c/osmo-gsm-manuals/+/12778/
* https://gerrit.osmocom.org/#/c/libosmocore/+/12777/

(I will add MSC handover related GSUP messages next, so having this simplified 
is already useful.)



--
To view, visit https://gerrit.osmocom.org/12408
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I801a0d6ffe09cfc75b77ab602bd25b3dc40f19c0
Gerrit-Change-Number: 12408
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 01 Feb 2019 15:12:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to