Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12408 )
Change subject: GSUP: fix missing osmo_gsup_get_err_msg_type()s ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/#/c/12408/1/src/gsm/gsup.c@96 PS1, Line 96: osmo_gsup_get_err_msg_type > I would also prefer the macro, so the function does not need to be adjusted > every time. […] while the existing GSUP message definitions "by coincidence" implicitly follow the rule that the error message is the request | 0x000001, I don't think this is indicated explicitly as a rule anywhere in the GSUP spec. I'm actually surprised that the macro exists. So if you want to make the rule explicit, make sure it's stated in the spec, there's a big fat comment on top of the enum/define for OSMO_GSUP_MSG_T and then make this function use the macro and mark it as deprecated. That should be a separate commit/patch from this one. -- To view, visit https://gerrit.osmocom.org/12408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I801a0d6ffe09cfc75b77ab602bd25b3dc40f19c0 Gerrit-Change-Number: 12408 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 21 Dec 2018 12:45:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
