Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12452 )
Change subject: gsup: add OSMO_GSUP_RAT_TYPES_IE ...................................................................... Patch Set 1: Code-Review-1 I finally found the ASN.1 definition of the RAT types indicator (search with a dash, doh), and this 'RAT Types indicator' is indeed intended as UpdateLocationArg, but for the VLR / SGSN capability sent towards the HLR, and not, it seems, about the current subscriber's connection? I can't find in 29.002 what the VLR/SGSN Capability bits are intended to be used for. It seems to me this patch's intention to use it to indicate the current conn's type is not accurate. Should we instead invent a custom separate IE (that transmits a single type instead of a list and makes things a lot simpler)? Is there another 29.002 IE that has slipped by my searching so far? -- To view, visit https://gerrit.osmocom.org/12452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93850710ab55a605bf61b95063a69682a2899bb1 Gerrit-Change-Number: 12452 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 03 Jan 2019 03:33:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
