Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12452 )
Change subject: gsup: add OSMO_GSUP_RAT_TYPES_IE ...................................................................... Patch Set 1: > i.e. the HLR tells the VLR whether access is allowed or not, hence this > should indeed be implemented differently than this patch suggests. yes, and the HLR simply sends whatever is stored in the database to the VLR. > This patch aimed at telling the HLR the RAT type during a LU; it worked well, > but protocol wise I see it now as little more than a hack. You can still add it as osmocom specific information. But the HLR shouldn't do anything with it other than logging or storing it for debugging purpose. -- To view, visit https://gerrit.osmocom.org/12452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93850710ab55a605bf61b95063a69682a2899bb1 Gerrit-Change-Number: 12452 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 03 Jan 2019 10:24:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
