Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12658 )
Change subject: add osmo_hexdump_b(), osmo_hexdump_nospc_b(), osmo_hexdump_buf() ...................................................................... Patch Set 3: Code-Review+1 I'm a bit skeptical about those "second static buffer" functions. If we, in general, added functions for a user-supplied bufer and one for a static buffer, it should be enough. Then a user who needs two buffers can put one buffer on his stack... and a user who needs three can do the same, without adding a _c() variant... -- To view, visit https://gerrit.osmocom.org/12658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I590595567b218b24e53c9eb1fd8736c0324d371d Gerrit-Change-Number: 12658 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 21 Jan 2019 18:50:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
