Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12658 )

Change subject: add osmo_hexdump_buf() and test
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/12658/6/src/utils.c
File src/utils.c:

https://gerrit.osmocom.org/#/c/12658/6/src/utils.c@265
PS6, Line 265: *cur++ = *delimp++;
> Why not to use delim itself?

Ah, ok, nevermind.



--
To view, visit https://gerrit.osmocom.org/12658
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I590595567b218b24e53c9eb1fd8736c0324d371d
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 11:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to