Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12658 )
Change subject: add osmo_hexdump_buf() and test ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/12658/5/src/utils.c File src/utils.c: https://gerrit.osmocom.org/#/c/12658/5/src/utils.c@230 PS5, Line 230: * \returns out_buf, containing a zero-terminated string, or NULL if out_buf == NULL or out_buf_size < 1. thinking now, maybe should rather return "" if the out_buf is NULL or zero length? -- To view, visit https://gerrit.osmocom.org/12658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I590595567b218b24e53c9eb1fd8736c0324d371d Gerrit-Change-Number: 12658 Gerrit-PatchSet: 5 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Tue, 22 Jan 2019 00:24:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
