Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c@429 PS4, Line 429: if (data->emergency) { > Yes. […] Odd that we're not using #define for it. Anyway, since we know the size and it's fixed than we should definitely use osmo_strlcpy(..., sizeof(data->called.number)) or alike. -- To view, visit https://gerrit.osmocom.org/12682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 10:33:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
