Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c@413 PS4, Line 413: static void check_setup(struct mncc_connection *conn, const char *buf, int rc) buf shouldn't be a const as well because you're effectively changing it for "emergency" case. https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c@425 PS4, Line 425: data = (struct gsm_mncc *) buf; Also, since you're changing data which points to the same memory as buf means that buf is no longer const as well. I'm surprised compiler doesn't complain about it. -- To view, visit https://gerrit.osmocom.org/12682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 10:10:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
