Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c@427 PS1, Line 427: if (data->emergency) { > > data->called is invalid […] OK wrong word "invalid" typed perhaps. so the next condition: ((data->fields & MNCC_F_CALLED) == 0) is going to be true in the case of an emergency call. I can't remember right now exactly the state of all the structs here in check_setup() but you could break and take a look. What I was actually stuck on was how to write a value to data->fields at this point, (and then let the argument screening continue) I tried and got a "it's read only" error. So, as Harald said, we could have the MSC populate it all, at the same time, to make it work with legacy nitb, I'd like to deal with it here. If you can help me write data->fields, I'd upload a patch without goto and with an if block. thnx. -- To view, visit https://gerrit.osmocom.org/12682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Fri, 25 Jan 2019 13:15:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
